Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update stylelint rules #142

Merged
merged 1 commit into from
Feb 22, 2024
Merged

chore: update stylelint rules #142

merged 1 commit into from
Feb 22, 2024

Conversation

dustin-jw
Copy link
Contributor

Description

This adjusts our stylelint rules to use the stylelint-config-standard-scss rules instead of stylelint-config-recommended-scss and uses more specific rules instead of turning off stock rules. It also adds a prettier configuration but without an enforcement mechanism (we'll have a little more consistency going forward, that's all).

To Validate

  1. Make sure all PR Checks have passed
  2. Pull down this branch
  3. Run npm start
  4. Confirm that the styles and behavior of the site remain unchanged

@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for triviaccessibility ready!

Name Link
🔨 Latest commit 6017bd2
🔍 Latest deploy log https://app.netlify.com/sites/triviaccessibility/deploys/65d76a5bb67c570008d4362c
😎 Deploy Preview https://deploy-preview-142--triviaccessibility.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dustin-jw dustin-jw force-pushed the chore--stylelint-rules branch from 6943a6c to 2146390 Compare December 4, 2023 15:39
@dustin-jw dustin-jw force-pushed the chore--stylelint-rules branch from 2146390 to 77c9789 Compare December 13, 2023 22:39
@dustin-jw dustin-jw force-pushed the chore--stylelint-rules branch from 77c9789 to b17524a Compare January 9, 2024 19:55
@dustin-jw dustin-jw force-pushed the chore--stylelint-rules branch 2 times, most recently from 709580d to 55bf73f Compare February 21, 2024 17:43
@dustin-jw
chore: use standard scss config over recommended
6017bd2 
- install/update dependencies
- fix linting issues from rule changes
- set up prettier config
@dustin-jw dustin-jw force-pushed the chore--stylelint-rules branch from 55bf73f to 6017bd2 Compare February 22, 2024 15:38
marissahuysentruyt
marissahuysentruyt approved these changes Feb 22, 2024
View reviewed changes
Copy link

@marissahuysentruyt marissahuysentruyt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I don't have a lot of context for this PR, but I think it's all good!

Just out of curiosity- what's the difference between using a stylelint.config.js file, and what we have here now, with .stylelintrc? Or why do you prefer doing the configurations in an "rc" file?

@dustin-jw
Copy link
Contributor Author

Looking good! I don't have a lot of context for this PR, but I think it's all good!

Just out of curiosity- what's the difference between using a stylelint.config.js file, and what we have here now, with .stylelintrc? Or why do you prefer doing the configurations in an "rc" file?

It's sort of a matter of preference. This one was changed to make copy-pasting from a reference repo easier, but I do like the convention of using .*rc files for configuration. That feels like a decent convention to distinguish config files from .js files that might get run as part of a build process.

@dustin-jw dustin-jw merged commit 6017bd2 into main Feb 22, 2024
6 checks passed
@dustin-jw dustin-jw deleted the chore--stylelint-rules branch February 22, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marissahuysentruyt marissahuysentruyt marissahuysentruyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustin-jw @marissahuysentruyt